Latest Posts

Topic: Bugs

kaputtnik
Avatar
Joined: 2016-06-18, 15:48
Posts: 50
Ranking
Likes to be here
Posted at: 2016-06-20, 19:25

Open bugs

Solved

  • Tooltips for images do not work (title=)
  • Special characters (like greater than or ampersand) do not work
  • Feeds do not work with wiki.
  • Saving username with wikiarticles
Edited: 2016-06-25, 01:18

Top Quote
einstein13
Avatar
Joined: 2016-06-21, 03:06
Posts: 8
Ranking
Pry about Widelands
Location: Poland
Posted at: 2016-06-21, 03:18

BUG: the strings here are changed while saving to database/ loading from it. When you want to write a special character (f.e.: greater than sign) you have strange results (pure html text)

TEST:
non alphabet signs: < > ! @ # $ % ^ & * ( ) ~ ` { } [ ] \ | ; : ' " , . /
polish charset: ? ? ? ? ? ? ? ? ? ? ó Ó ? ? ? ? ? ?
german and french letters need tests face-wink.png

EDIT: Yesterday I could see polish letters. Today they are question marks. Is this a system-browser problem? (Windows - Linux)

? ? ? ? ? ? ? ? ? ? ó Ó ? ? ? ? ? ?

Also let's try star1 star2 star3 under1 under2 under3
I think that in messages markdown syntax doesn't work well (see your response, kaputtnik)

Edited: 2016-06-21, 16:26

Hey, this is my wrong signature :P

Top Quote
kaputtnik
Avatar
Joined: 2016-06-18, 15:48
Posts: 50
Ranking
Likes to be here
Posted at: 2016-06-21, 11:32

Ah, special characters.... lets try german:

Ä ä Ü ü Ö ö ß


Top Quote
einstein13
Avatar
Joined: 2016-06-21, 03:06
Posts: 8
Ranking
Pry about Widelands
Location: Poland
Posted at: 2016-06-21, 16:27

I guess that there is a problem with database encoding, but I am not sure! face-wink.png


Hey, this is my wrong signature :P

Top Quote
kaputtnik
Avatar
Joined: 2016-06-18, 15:48
Posts: 50
Ranking
Likes to be here
Posted at: 2016-06-21, 22:23

einstein13 wrote:

I guess that there is a problem with database encoding, but I am not sure! face-wink.png

Indeed, thanks for the hint on that. The current set is for the database and for the related pybb table: latin1 | latin1_swedish_ci face-confused.png

I have changed that so special characters should be saved correctly now:

polish charset: ą Ą ć Ć ę Ę ł Ł ń Ń ó Ó ś Ś ż Ż ź Ź

But this wouldn't solve the problem with the "greater/lesser than" sign (>) and the ampersand (&)


Top Quote
einstein13
Avatar
Joined: 2016-06-21, 03:06
Posts: 8
Ranking
Pry about Widelands
Location: Poland
Posted at: 2016-06-22, 03:09

kaputtnik wrote:

But this wouldn't solve the problem with the "greater/lesser than" sign (>) and the ampersand (&)

Messages in other parts are shown well (see my comment under poll)

Is this a valid code?: http://bazaar.launchpad.net/~widelands-dev/widelands-website/django1_8/files

My first guess:

I'm not sure if it is required, but maybe "safe" filter?
https://docs.djangoproject.com/en/1.8/ref/templates/builtins/#safe

But the line here is OK.

Second guess was database (before saving the message, signs are changed), but when I quoted your message, in textarea correct signs appeared.

Another strange thing is that only 3 of 5 signs are changed (django can change also other signs). Why? Don't know! face-sad.png

EDIT: another quess about "preview" button (when editing & creating posts):

http://bazaar.launchpad.net/~widelands-dev/widelands-website/django1_8/view/head:/pybb/views.py#L354 (LINE 354)
There is "urlize" function. I don't know what it is doing. Maybe commenting it and testing will answer the question.
Another hint here: http://nullege.com/codes/show/src@p@y@pybb-HEAD@pybb@models.py/176/pybb.util.unescape
Maybe unescaping will help? I don't know. that are only guesses.

Edited: 2016-06-22, 03:29

Hey, this is my wrong signature :P

Top Quote
kaputtnik
Avatar
Joined: 2016-06-18, 15:48
Posts: 50
Ranking
Likes to be here
Posted at: 2016-06-22, 10:36

Displaying the posts use already the filter "|safe", so thats not the problem. The problem is that @gt; get saved as @amp;gt;.

I look into it this evening again. Thanks for your replys, they are helping a lot face-smile.png

Edited: 2016-06-22, 10:42

Top Quote
kaputtnik
Avatar
Joined: 2016-06-18, 15:48
Posts: 50
Ranking
Likes to be here
Posted at: 2016-06-22, 10:49

kaputtnik wrote:

Displaying the posts use already the filter "|safe", so thats not the problem. The problem is that @gt; get saved as @amp;gt;.

I look into it this evening again. Thanks for your replys, they are helping a lot face-smile.png

Edit:
The problem is that @gt; get changed into @amp;gt;.

Edit2 for testing

Edited: 2016-06-22, 20:21

Top Quote
einstein13
Avatar
Joined: 2016-06-21, 03:06
Posts: 8
Ranking
Pry about Widelands
Location: Poland
Posted at: 2016-06-22, 21:27

Another bug (probably it is both here and on official page) is about making Wiki links. If you write GunChleoc nickname in maps comment, you will raise this bug. See my comments under first uploaded map.


Hey, this is my wrong signature :P

Top Quote
kaputtnik
Avatar
Joined: 2016-06-18, 15:48
Posts: 50
Ranking
Likes to be here
Posted at: 2016-06-22, 22:29

einstein13 wrote:

Another bug (probably it is both here and on official page) is about making Wiki links. If you write GunChleoc nickname in maps comment, you will raise this bug. See my comments under first uploaded map.

This is not a bug it's a feature face-wink.png No, not really face-grin.png Once the wiki was programmed the decision was made to create "easy" wikilinks: Wikiarticles should be named with at least two upper case letters in one word. Such words (like "WikiHelp" or "GameHelp" or, in this case, "GunChleoc") could be easily matched with a regular expression and if some writes it (only the word) in a Wiki article the Word get transformed to a wikipage url. For the forum (and only there) this "wikiwordification" is disabled. The consensus is now to get rid of this function in future and instead use the markdown wikilinks syntax. This is another big task and i don't want to work on this until we have updated Django. The same goes for all the other website related bugs. Working on bugs with an outdated codebasis is imho useless. But thanks for pointing this out, i will create a bug report for this as a reminder face-smile.png


Top Quote